Skip to content
This repository was archived by the owner on Apr 5, 2023. It is now read-only.

[BUG] Prevent rendering issue with the SelectComponent when it has focus #316

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[BUG] Prevent rendering issue with the SelectComponent when it has focus #316

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d2c3a0
the fix?
cyril-sf Oct 10, 2019
893373b
Another fix?
cyril-sf Oct 11, 2019
bebcace
Avoid state change during rendering
mixonic Oct 17, 2019
d13e610
Revert change in focusIn / focusOut
cyril-sf Oct 18, 2019
01d234b
Use setFocus
cyril-sf Oct 18, 2019
4f70089
Code cleanup
cyril-sf Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions addon/components/select-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,12 +674,16 @@ export default Ember.Component.extend(
return this.sendAction('userSelected', selection);
},

focusIn: function() {
return this.set('hasFocus', true);
focusIn: function(event) {
if (event.target.tagName === 'INPUT') {
this.set('hasFocus', true);
}
},

focusOut: function() {
return this.set('hasFocus', false);
focusOut: function(event) {
if (event.target.tagName === 'INPUT') {
this.set('hasFocus', false);
}
},

actions: {
Expand Down
2 changes: 1 addition & 1 deletion addon/mixins/popover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default Ember.Mixin.create(StyleBindingsMixin, BodyEventListener, {
}).property('contentViewClass'),
didInsertElement: function() {
this._super();
Ember.run.schedule('afterRender', this, () => {
Ember.run.schedule('afterRender', () => {
this.snapToPosition();
this.set('visibility', 'visible');
this.set('isShowing', true);
Expand Down