-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Description
target-atjs-extensions/react/component/src/component.jsx
Lines 24 to 26 in f689187
| componentWillReceiveProps(newProps) { | |
| return onComponentWillReceiveProps(this, this.logger, newProps); | |
| } |
As per the React documentation, componentWillReceiveProps is a deprecated method, slated for removal in v17.
One possible solution would be to change the implementation of shouldComponentUpdate and then leverage componentDidUpdate (I am aware of #37 which may or may not make this possible).
Otherwise another option may be to trigger these side effects in the shouldComponentUpdate call, which seems like an anti pattern but is the first and only method that would be called if the implementation stays as returning false.
Metadata
Metadata
Assignees
Labels
No labels