Skip to content

React component uses deprecated lifecycle methods #43

@breeny

Description

@breeny

componentWillReceiveProps(newProps) {
return onComponentWillReceiveProps(this, this.logger, newProps);
}

As per the React documentation, componentWillReceiveProps is a deprecated method, slated for removal in v17.

One possible solution would be to change the implementation of shouldComponentUpdate and then leverage componentDidUpdate (I am aware of #37 which may or may not make this possible).

Otherwise another option may be to trigger these side effects in the shouldComponentUpdate call, which seems like an anti pattern but is the first and only method that would be called if the implementation stays as returning false.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions