Merge pull request #18 from AdrianJSClark/add-options

Rename Main Client, User/Pass on Options, Client Interface Extracted, Save/Restore Cookies

Author: AdrianJSClark

README.md

@@ -25,28 +25,26 @@ dotnet add package Aydsko.iRacingData
 Register the iRacing Data API client classes with the service provider.
 
 ```csharp
-services.AddiRacingDataApi();
+services.AddiRacingDataApi(options => { options.Username = "your-iracing-user@example.com"; options.Password = "Your-iRacing-Password"; });
 ```
 
 ## Use the Client
 
-Use the injected `iRacingDataClient` to authenticate and request data.
+Use the injected `IDataClient` to authenticate and request data.
 
 ```csharp
 public class ExampleService
 {
-    private readonly iRacingDataClient dataClient;
+    private readonly IDataClient dataClient;
 
-    public ExampleService(iRacingDataClient dataClient)
+    public ExampleService(IDataClient dataClient)
     {
         this.dataClient = dataClient;
     }
 
-    public Task<MemberInfo> GetMyInfoAsync(string username, string password, CancellationToken cancellationToken = default)
+    public async Task<MemberInfo> GetMyInfoAsync(CancellationToken cancellationToken = default)
     {
-        await dataClient.LoginAsync(username, password, cancellationToken);
         var infoResponse = await dataClient.GetMyInfoAsync(cancellationToken);
-
         return infoResponse.Data;
     }
 }

examples/Console/iRacingConsole/Program.cs

@@ -1,11 +1,6 @@
 using Microsoft.Extensions.DependencyInjection;
 using Aydsko.iRacingData;
 
-using var provider = new ServiceCollection().AddIRacingDataApi()
-                                            .BuildServiceProvider();
-
-using var appScope = provider.CreateScope();
-
 Console.WriteLine("Aydsko iRacing Data API Example Console Application");
 
 Console.WriteLine();
@@ -22,15 +17,21 @@
     return;
 }
 
-var iRacingClient = provider.GetRequiredService<iRacingDataClient>();
-await iRacingClient.LoginAsync(username, password);
+var services = new ServiceCollection();
+services.AddIRacingDataApi(options =>
+{
+    options.Username = username;
+    options.Password = password;
+});
 
-Console.WriteLine();
-Console.WriteLine("Login successful!");
+using var provider = services.BuildServiceProvider();
+using var appScope = provider.CreateScope();
 
+var iRacingClient = provider.GetRequiredService<IDataClient>();
 var myInfo = await iRacingClient.GetMyInfoAsync();
 
 Console.WriteLine();
+Console.WriteLine("Request successful!");
 Console.WriteLine($@"Driver name: {myInfo.Data.DisplayName}
 Customer ID: {myInfo.Data.CustomerId}
 Club: {myInfo.Data.ClubName}");

examples/Console/iRacingConsole/iRacingConsole.csproj

@@ -8,7 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Aydsko.iRacingData" Version="0.0.6" />
+    <PackageReference Include="Aydsko.iRacingData" Version="0.1.0" />
   </ItemGroup>
 
 </Project>

src/.editorconfig

@@ -16,7 +16,7 @@ csharp_new_line_before_members_in_anonymous_types = false
 #require members of object intializers to be on separate lines
 csharp_new_line_before_members_in_object_initializers = true
 #require braces to be on a new line for methods, types, and control_blocks (also known as "Allman" style)
-csharp_new_line_before_open_brace = methods, types, control_blocks
+csharp_new_line_before_open_brace = all
 
 #Formatting - organize using options
 
@@ -133,6 +133,8 @@ csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
 csharp_style_prefer_extended_property_pattern = true:suggestion
 csharp_style_prefer_not_pattern = true:suggestion
 dotnet_diagnostic.CA1812.severity = silent
+csharp_style_prefer_method_group_conversion = true:silent
+insert_final_newline = true
 
 [*.{cs,vb}]
 dotnet_style_operator_placement_when_wrapping = beginning_of_line