-
Notifications
You must be signed in to change notification settings - Fork 1
Accessibility improvements for filter bar #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: group/a11y-fixes
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @glad-adyen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the FilterBar
component to enhance its accessibility and testability. The primary change involves removing a redundant accessible name that could cause verbose announcements for screen reader users, while simultaneously introducing a data-testId
for more robust automated testing.
Highlights
- Accessibility Improvement: Removed an unnecessary
aria-label
from the mainFilterBar
container element. This prevents redundant announcements by screen readers, improving the overall accessibility experience for users of assistive technologies. - Testability Enhancement: Replaced the reliance on an
aria-label
for component identification with adata-testId
attribute on theFilterBar
component. This streamlines automated testing by providing a stable, non-localized identifier.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the accessibility of the FilterBar
component by removing an unnecessary aria-label
from its container and using data-testId
for locating the element in tests. The related translation keys have also been removed.
# Conflicts: # tests/models/internal-components/filterBar.ts
5c440e9
to
986b141
Compare
00d424a
to
a6795b3
Compare
a6795b3
to
5826a8c
Compare
Summary
This PR introduces the following changes to improve the accessibility of the filter bar controls rendered within the
<FilterBar />
component for several external UI components such as: TransactionsOverview, DisputesOverview, etc.<AmountFilter />
Addresses:
Related to: CXP-3361