Skip to content

Conversation

glad-adyen
Copy link
Contributor

@glad-adyen glad-adyen commented Aug 4, 2025

Summary

This PR introduces the following changes to improve the accessibility of the filter bar controls rendered within the <FilterBar /> component for several external UI components such as: TransactionsOverview, DisputesOverview, etc.

  • Add accessible names and labels to filter bar landmark region and interactive controls
  • Fix filter display value for <AmountFilter />

Addresses:

  • piefp-3 — Ensure custom controls provide proper textual name, role, and state information
  • piefp-4 — Ensure custom controls provide proper textual name, role, and state information
  • piefp-12 — Ensure ARIA roles, states, and properties are valid
  • piefp-28 — Ensure custom controls provide proper textual name, role, and state information
  • piefp-29 — Ensure custom controls provide proper textual name, role, and state information
  • piefp-31 — Ensure ARIA roles, states, and properties are valid
  • piefp-39 — Ensure custom controls provide proper textual name, role, and state information

Related to: CXP-3361

@glad-adyen glad-adyen self-assigned this Aug 4, 2025
@glad-adyen glad-adyen changed the base branch from develop to group/a11y-fixes August 4, 2025 14:33
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @glad-adyen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the FilterBar component to enhance its accessibility and testability. The primary change involves removing a redundant accessible name that could cause verbose announcements for screen reader users, while simultaneously introducing a data-testId for more robust automated testing.

Highlights

  • Accessibility Improvement: Removed an unnecessary aria-label from the main FilterBar container element. This prevents redundant announcements by screen readers, improving the overall accessibility experience for users of assistive technologies.
  • Testability Enhancement: Replaced the reliance on an aria-label for component identification with a data-testId attribute on the FilterBar component. This streamlines automated testing by providing a stable, non-localized identifier.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@glad-adyen glad-adyen changed the title Accessibility improvements for filter bar Accessibility improvements for filter bar [DRAFT] Aug 4, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the accessibility of the FilterBar component by removing an unnecessary aria-label from its container and using data-testId for locating the element in tests. The related translation keys have also been removed.

@glad-adyen glad-adyen changed the title Accessibility improvements for filter bar [DRAFT] Accessibility improvements for filter bar Sep 2, 2025
@glad-adyen glad-adyen marked this pull request as ready for review September 2, 2025 16:02
@glad-adyen glad-adyen requested a review from a team as a code owner September 2, 2025 16:02
@glad-adyen glad-adyen force-pushed the a11y/filter-bar branch 6 times, most recently from 5c440e9 to 986b141 Compare September 3, 2025 14:15
@glad-adyen glad-adyen force-pushed the a11y/filter-bar branch 5 times, most recently from 00d424a to a6795b3 Compare September 3, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant