Accessibility improvements for modal dismiss button

[glad-adyen]

Summary

This PR includes minor style and accessible name (label) updates for <Modal /> dismiss buttons. Some changes also led to the removal of redundant styles and markup elements.

• Visible focus indicator for dismiss button
• Semantic class name for dismiss button

Addresses:

• piefp-14 — Ensure custom controls provide proper textual name, role, and state information
• piefp-17 — Ensure keyboard focus is indicated visually
• piefp-19 — Ensure custom controls provide proper textual name, role, and state information
• piefp-23 — Ensure keyboard focus is indicated visually
• piefp-35 — Ensure custom controls provide proper textual name, role, and state information
• piefp-37 — Ensure keyboard focus is indicated visually

Related to: CXP-3361

[gemini-code-assist]

Summary of Changes

Hello @glad-adyen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've made accessibility improvements to modal dismiss buttons. This PR focuses on updating styles and accessible names, and also includes refactoring to remove redundant styles and markup, streamlining the modal component structure.

Highlights

• Modal Styling Consolidation: I've refactored the styling for modal content by consolidating previously scattered styles from DisputeManagementModal.scss and ModalContent.scss into a new __content class within Modal.scss. This centralizes modal content padding and error message display styles, allowing for the removal of the two separate SCSS files.
• Accessibility Enhancements for Dismiss Button: I've improved the accessibility of the modal dismiss button by renaming its CSS class from __header-icon to __dismiss-button for better semantic clarity. Additionally, I've added a focus-visible outline to the dismiss button, enhancing keyboard navigation and usability for users.
• Markup Simplification: I've simplified the HTML structure within DisputeManagementModal.tsx and ModalContent.tsx by removing redundant div wrappers. This change directly aligns with the consolidation of modal content styles, making the component hierarchy cleaner and more efficient.
• Class Name Refactoring: I've updated the class name for the modal title from adyen-pe-modal__header__title to adyen-pe-modal__header-title in Modal.tsx for consistency and improved readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces accessibility improvements for the modal dismiss button by renaming its CSS class for better clarity and adding a focus-visible style. Additionally, it refactors modal-related styles by consolidating them into Modal.scss and removing redundant wrapper elements and SCSS files, which improves code organization. My review includes a couple of suggestions for further code cleanup and consistency.