-
Notifications
You must be signed in to change notification settings - Fork 1
A11y improvements [DRAFT] #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
glad-adyen
wants to merge
29
commits into
develop
Choose a base branch
from
group/a11y-fixes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added live region for "Copied" status announcements - Repurposed and renamed `buttonLabel` prop to `buttonLabelKey`, to provide accessible name for copy button - Added new `visibleText` prop to take on the previous behavior of the `buttonLabel` prop - Refactored class names and render logic for better organization
Minor accessibility improvements
Fix focus trap
- remove unnecessary ARIA labels from structured list - refactored locator for transaction details **Reference ID**
Merge develop into group/a11y-fixes
Accessibility improvements for copy text component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aggregates lots of small accessibility improvements and fixes across multiple components, based on issues and findings reported from prior accessibility review and audit.