-
Notifications
You must be signed in to change notification settings - Fork 1
Retrieve assets from CDN #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: group/move-assets-to-cdn
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @german664, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors how the application retrieves static assets like images and translations. Instead of relying solely on local asset bundles, the system can now fetch these resources from a Content Delivery Network (CDN). This change introduces new environment configurations, updates core context providers, enhances the HTTP client for CDN-specific requests, and centralizes asset management through a new Resources
class. The primary goal is to improve performance and scalability by leveraging CDN capabilities for faster content delivery.
Highlights
- CDN Environment Configuration: This PR introduces a new
USE_CDN
environment variable and integrates it into the application's environment parsing, allowing developers to easily switch between local asset loading and CDN-based asset loading. - Centralized Asset Loading: The core asset loading mechanisms for images and translations have been refactored. Images now use a new
Resources
class, and translations are fetched via HTTP from CDN endpoints, significantly improving asset delivery efficiency. - Core Context Enhancement: The
CoreContext
and its associated types have been updated to include aresources
object, providing a centralized and consistent way to access CDN-managed assets throughout the application's components. - HTTP Client Flexibility: The internal HTTP client has been extended with
versionless
andskipContentType
options, offering greater flexibility when making requests to CDN endpoints that may not adhere to standard API versioning or content type headers. - Dynamic CDN URL Resolution: The environment resolution utility now provides specific CDN URLs for both translations and images, ensuring that the application correctly points to the right CDN endpoints based on the configured environment (e.g., test or live).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and well-structured change to retrieve assets like images and translations from a CDN instead of local paths. This is achieved through a new Resources
service and substantial updates to the Localization
and Http
services. The changes are comprehensive and improve the architecture for handling assets. I've identified one potential high-severity bug in how POST request bodies are handled and a couple of medium-severity areas for code clarification and improvement.
|
||
export const CDN_ENVIRONMENTS = { | ||
test: 'https://18e8543875.cdn.adyen.com/platform-components/v1-cdn-test', | ||
live: 'https://18e8543875.cdn.adyen.com/platform-components/v1-cdn-live', // TODO change to right LIVE url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Glad Chinda <117656861+glad-adyen@users.noreply.github.com>
Co-authored-by: Glad Chinda <117656861+glad-adyen@users.noreply.github.com>
Co-authored-by: Glad Chinda <117656861+glad-adyen@users.noreply.github.com>
Summary
Request assets from the new CDN endpoints.
Fixed issue: CXP-3861