Skip to content

feat: add support for terminal region #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

idl3
Copy link
Contributor

@idl3 idl3 commented Jul 29, 2024

Description

  • feat: added support for terminal cloud API endpoints that are regional

Tested scenarios

  • By default terminal region is nil
  • If terminal region is supplied we will suffix the api endpoint with the region.

Fixed issue:
#255

@idl3 idl3 requested a review from a team July 29, 2024 16:38
Copy link

@DjoykeAbyah
Copy link
Member

DjoykeAbyah commented Aug 1, 2024

Hi @idl3!

Thank you for contributing this feature! We're merging it to implement your changes.

Kind regards,
Djoyke
Adyen

@DjoykeAbyah DjoykeAbyah merged commit 840e786 into Adyen:main Aug 1, 2024
8 checks passed
@idl3 idl3 deleted the feat/add-terminal-regional-endpoint branch August 2, 2024 01:54
@idl3 idl3 restored the feat/add-terminal-regional-endpoint branch August 14, 2024 02:47
DjoykeAbyah pushed a commit that referenced this pull request Feb 10, 2025
* feat: add support for terminal region

* fix: use not nil? instead of present?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants