Fix merchant reference could be null #663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version 4.2.12
wrongspot
requested review from
brankologeecom,
MarijaIv,
tamaralogeecom,
AleksandarBoljanovic,
goran-stamenkovski-logeecom and
teodoratimoti
as code owners
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if the sandbox account is used on several server instances, it can happen that there are reference ids that do not match the current shop. in that case, $merchantReference is null and then application crashes, because https://github.com/wrongspot/adyen-shopware6/blob/develop/src/Service/Repository/OrderRepository.php#L91 in next line
getOrderByOrderNumberneeds as first argument a stringTested scenarios
Fixed issue: