Skip to content

.swiftinterface file support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Oct 15, 2024
Merged

.swiftinterface file support #21

merged 48 commits into from
Oct 15, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Oct 7, 2024 •
edited
Loading

Summary

The public api diff now uses swift-syntax to parse .swiftinterface files instead of relying on abi.json files that can be incomplete and do not expose features like actor, async, ...

TODOs

  • Remove all SDKDump related code
  • Fix documentation
  • Implement missing UnitTests
  • Update README.md with new flows

Target structure

Executable Targets

  • CommandLineTool

Public Modules

  • PADProjectBuilder
    • Fetches remote projects (optional)
    • Archives projects
    • Produces a list of SwiftInterfaceFiles, package-changes + warnings
  • PADPackageFileAnalyzer
    • Inspects the Package.swift
    • Produces a list of changes/warnings
  • PADSwiftInterfaceAnalyzer
    • Takes a list of SwiftInterfaceFiles
    • Produces a list of changes per SwiftInterfaceFile
  • PADOutputGenerator
    • Generates output for changes & warnings

Shared/Public

  • PADCore
    • Containing shared types
  • PADLogging
    • Everything about logging

Shared/Package

  • FileHandlingModule
    • Everything regarding file handling
  • ShellModule
    • Interacting with the shell
  • SwiftPackageFileHelperModule
    • Swift Package tools (e.g. parsing, modifying, ...)

See: #13

@goergisn goergisn linked an issue Oct 7, 2024 that may be closed by this pull request
🧮 Add support for binary frameworks (.swiftinterface) #13
Closed
@goergisn
Fixing integration tests
637abd7
@goergisn
Merge branch 'main' into swiftinterface-file-support
d803935 
# Conflicts:
#	Sources/Pipeline/Modules/SwiftPackageFileAnalyzer.swift
#	Sources/Pipeline/SDKDumpPipeline.swift
#	Tests/UnitTests/PipelineTests.swift
#	Tests/UnitTests/SDKDumpAnalyzerTests.swift
#	Tests/UnitTests/SwiftPackageFileAnalyzerTests.swift
@goergisn
Fixing file name
6fc4ffb
@goergisn
Simplifying and fixing logic
7a0bcd5
@goergisn
fixing dependency resolving
26ff072
@goergisn
fixing build
665c45e
@goergisn goergisn requested a review from Robert-SD October 9, 2024 09:29
@goergisn goergisn marked this pull request as ready for review October 10, 2024 10:15
@atmamont
Copy link

It's quite impossible to review, any particular part to look for? Otherwise, I'd just approve

@goergisn
Copy link
Contributor Author

It's quite impossible to review, any particular part to look for? Otherwise, I'd just approve

I'll go through the major changes tomorrow :)

goergisn and others added 7 commits October 10, 2024 15:21
@goergisn
fixing output
8a6bd75
@goergisn
Modularize Package.swift (#27)
6ec7920 
* Moving files around

* Better modularization

* Removing unused code

* More modularization

* fixing Package.swift file

* some fixes

* Renaming

* Renaming

* Renaming

* More renaming

* Restructuring

* Adding swift-docc plugin

---------

Co-authored-by: Alex Guretzki <alexander.guretzki@adyen.com>
@goergisn
Adding more documentation
1ada9a7
@goergisn
Fixing test
bf99220
@goergisn
More documentation
6e3fae7
@goergisn
Update README.md
7208f82
@goergisn
Updating documentation
6d84af0
@goergisn goergisn linked an issue Oct 11, 2024 that may be closed by this pull request
📓 Github README.md with how to use guide #29
Closed
@goergisn goergisn merged commit c138ff1 into main Oct 15, 2024
2 checks passed
@goergisn goergisn deleted the swiftinterface-file-support branch October 15, 2024 08:16
nauaros
nauaros reviewed Oct 15, 2024
View reviewed changes
Copy link

@nauaros nauaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nauaros nauaros nauaros left review comments

@atmamont atmamont atmamont approved these changes

@Robert-SD Robert-SD Awaiting requested review from Robert-SD

@erenbesel erenbesel Awaiting requested review from erenbesel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📓 Github README.md with how to use guide 🧮 Add support for binary frameworks (.swiftinterface)
3 participants
@goergisn @atmamont @nauaros