fix: unregister video frame delegate in dealloc of TextureRender to a… (#2296)

…void crash

Author: peilinok

shared/darwin/TextureRenderer.mm

@@ -208,6 +208,14 @@ - (void)dispose {
 }
 
 - (void)dealloc {
+  if (self.irisRtcRendering) {
+    // the delegateId is garenteed to be auto incremented, so we can just remove
+    // the delegate by the id, no need to check if the delegate is still valid
+    // or is belong to this TextureRender
+    self.irisRtcRendering->RemoveVideoFrameObserverDelegate(self.delegateId);
+    self.irisRtcRendering = nil;
+  }
+
   dispatch_sync(self.pixelBufferSynchronizationQueue, ^{
     if (self.latestPixelBuffer) {
       CVPixelBufferRelease(self.latestPixelBuffer);

shared/darwin/VideoViewController.mm

@@ -246,4 +246,11 @@ - (void)dispose {
     [self.textureRenders removeAllObjects];
 }
 
+// - (void)dealloc {
+//   // do not do this, coz TextureRender::TextureRender will call
+//   // [textureRegistry unregisterTexture] which may already been dealloced by
+//   // flutter and will bring crash
+//   // [self dispose];
+// }
+
 @end