DisCatSharp v10.7.0 Release #661
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
force-pushed
the
release/v10.7.0
branch
4 times, most recently
from
5e45d23 to
b42f215
Compare
|
Documentation test build passed! 🎉 |
Lulalaby
force-pushed
the
release/v10.7.0
branch
3 times, most recently
from
5fcd853 to
c536d19
Compare
3 tasks
Lulalaby
force-pushed
the
release/v10.7.0
branch
from
46d1d6c to
0101d86
Compare
Lulalaby
force-pushed
the
release/v10.7.0
branch
4 times, most recently
from
e1cb70c to
128c223
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the v10.7.0 release by updating attribute classes, migrating solution file references in GitHub workflows from “.sln” to “.slnx”, and introducing nullable reference types in selected ApplicationCommands contexts.
- Updated attribute classes to remove the Inherited option on AttributeUsage and adjust property declarations.
- Revised multiple CI/CD workflow files to reference the new “.slnx” solution file and update working directories.
- Modified ApplicationCommands context classes to use nullable types for properties where a value may be absent.
Reviewed Changes
Copilot reviewed 122 out of 125 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DisCatSharp.Attributes/RequiresOverrideAttribute.cs | New attribute for requiring overrides with updated constructor/property definitions. |
| DisCatSharp.Attributes/DiscordInExperimentAttribute.cs | Updated attribute usage and property declarations. |
| DisCatSharp.Attributes/RequiresFeatureAttribute.cs | Revised attribute constructors and property ordering. |
| DisCatSharp.Attributes/DiscordUnreleasedAttribute.cs | Updated attribute usage and property declarations. |
| DisCatSharp.Attributes/Features.cs | Added an “Unknown” feature and reorganized FeatureDescriptionAttribute. |
| DisCatSharp.Attributes/DeprecatedAttribute.cs | Updated attribute usage and property declarations. |
| DisCatSharp.Attributes/DiscordDeprecatedAttribute.cs | Updated attribute usage and property declarations. |
| DisCatSharp.Attributes/ExperimentalAttribute.cs | Updated attribute usage and property declarations. |
| .github/workflows/documentation_test.yml | Adjusted restore/build commands and working directories to match the new solution file. |
| .github/workflows/public-dev-release.yml | Changed solution file reference from “.sln” to “.slnx”. |
| .github/workflows/codeql-analysis.yml | Updated solution file references for restore and build steps. |
| .github/workflows/build.yml | Modified restore/build commands to use “.slnx”. |
| .github/workflows/internal-release.yml | Modified restore commands to use “.slnx”. |
| .github/workflows/documentation.yml | Updated restore/build commands to use “.slnx”. |
| DisCatSharp.ApplicationCommands/Context/AutocompleteContext.cs | Changed properties to be nullable to accurately represent possible absence of data. |
| DisCatSharp.ApplicationCommands/Context/BaseContext.cs | Changed properties to be nullable and removed deprecated members. |
| .github/workflows/release.yml | Updated restore commands for DisCatSharp and related projects to use “.slnx”. |
Files not reviewed (3)
- Directory.Build.props: Language not supported
- DisCatSharp.ApplicationCommands/DisCatSharp.ApplicationCommands.csproj: Language not supported
- DisCatSharp.Attributes/DisCatSharp.Attributes.csproj: Language not supported
Comments suppressed due to low confidence (3)
DisCatSharp.ApplicationCommands/Context/AutocompleteContext.cs:29
- [nitpick] Since the 'Guild' property is now nullable, update its XML documentation to clearly indicate that it may be null when the interaction occurs in a DM.
public DiscordGuild? Guild { get; internal init; }
.github/workflows/public-dev-release.yml:22
- Changing the solution reference from '.sln' to '.slnx' is critical; please verify that all related build configurations and dependent workflows are updated accordingly.
- - "DisCatSharp.sln"
.github/workflows/build.yml:46
- Ensure that using 'DisCatSharp.slnx' here is intentional and consistent with the project structure across all CI/CD configurations.
dotnet restore --no-cache -f -v minimal DisCatSharp.slnx
dcc9d96 to
d5525ce
Compare
Lulalaby
added
bug
Added null-coalescing assignment to initialize AttachmentsInternal in various AddGcpAttachment methods. This prevents potential null reference exceptions when adding attachments.
Updated the `waveform` parameter in the `AddManualGcpAttachment` method to use a byte array instead of a UTF-8 encoded string. This simplifies the handling of waveform data and removes the need for encoding conversions.
Introduced a new constructor and properties in RequireRolesAttribute to allow role checks using role IDs in addition to role names. Updated the ExecuteCheckAsync method to handle both role names and role IDs based on the UsesRoleIds flag.
Replaced direct `DiscordColor` properties with raw string properties for JSON serialization and added computed properties to convert raw strings to `DiscordColor`. This improves flexibility and ensures proper handling of color data.
Added a check to ensure `context.Options` has elements before filtering slash commands by name. This prevents potential null reference exceptions when `context.Options` is empty.
Added checks to ensure `context.Options[0].Value` is not null or empty before processing autocomplete logic. This prevents potential null reference exceptions when handling slash command options.
Introduced a new 'Hidden' flag in the SpeakingFlags enum, which likely indicates that the user is not visible in the channel. This change adds support for handling this new flag.
Introduced a new `Autocomplete` command type in `DisCatSharpCommandType` and updated related contexts to support it. Added properties and annotations to enhance interaction handling and context initialization for autocomplete interactions.
Removed the `Client` property from `AutocompleteContext` as it is no longer needed. Updated `ComponentInteractionCreateEventArgs` to use `Interaction.Guild` for the `Guild` property and added a nullable `Member` property with a nullability annotation for better type safety.
Updated the GuildJoinedAt property in DiscordMemberPaginationFilter to have a default value of 0, ensuring it is always initialized and removing the nullable type.
Introduced a new method `WithStickerIds(IEnumerable<ulong> stickerIds)` to allow adding multiple stickers to a message. Ensures that no more than 4 stickers are added, adhering to Discord's limitations.
Updated `DiscordUnfurledMedia.Url` to be nullable and added a JSON property annotation to `DiscordCollectibles.Nameplate`. Also included a missing `using Newtonsoft.Json` directive in `DiscordCollectibles.cs`.
Added 'Newtonsoft.Json' to InternalsVisibleTo.targets for internal visibility. Changed DiscordUnfurledMedia.Url to non-nullable. Refactored DiscordApiClient to use ToDiscordObject for deserialization, improving consistency.
Introduced `FullCommandName` and `CommandName` overrides in `CommandContext` to provide access to command names. Updated `DisCatSharpCommandContext` to make `CommandName`, `SubCommandName`, and `SubSubCommandName` virtual for better extensibility.
Updated all RespondAsync method overloads in DiscordMessage.cs to include an optional 'mention' parameter, allowing control over whether the reply mentions the original message author. This enhances flexibility when responding to messages.
Renamed GCP attachment-related files from 'Message' to 'Channel' for better organization. Added a new 'DiscordMessageBuilderMethodHooks' class to centralize and extend GCP attachment handling methods. Removed the old 'DiscordMessageBuilderMethodHooks' file to avoid redundancy.
Added checks for voice message flags and improved attachment handling in DiscordApiClient methods. Renamed DiscordMessageBuilderMethodHooks.cs to DisCatSharpBuilderMethodHooks.cs for better clarity. Updated project file to include a new folder for message entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.