[Unity3D-sdk] Remove dependency on TextMeshPro from ugui/UnityNode.cs#111
Open
KorneiDontsov wants to merge 1 commit intoAirtestProject:masterfrom
Open
[Unity3D-sdk] Remove dependency on TextMeshPro from ugui/UnityNode.cs#111KorneiDontsov wants to merge 1 commit intoAirtestProject:masterfrom
KorneiDontsov wants to merge 1 commit intoAirtestProject:masterfrom
Conversation
Documentation in README says that folder 'ugui' should be chosen when target project uses UnityEngine.UI without TextMeshPro. But at the moment ugui/UnityNode.cs is not working without TextMeshPro. These changes fix it. The commit actually roll back the changes made in commit 90376b9 last year. Probably, they was forgotten to roll back when TextMeshPro support was split to separate folder 'uguiWithTMPro'.
Author
|
Compilation error that occurs and needs fixing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation in README says that folder 'ugui' should be chosen when target project uses UnityEngine.UI without TextMeshPro. But at the moment ugui/UnityNode.cs is not working without TextMeshPro. These changes fix it.
The commit actually roll back the changes made in commit 90376b9 last year. Probably, they was forgotten to roll back when TextMeshPro support was split to separate folder 'uguiWithTMPro'.