feat(temperature): add hwmon-name option for stable sensor selection#4723
Open
ChaosInfinited wants to merge 3 commits intoAlexays:masterfrom
Open
feat(temperature): add hwmon-name option for stable sensor selection#4723ChaosInfinited wants to merge 3 commits intoAlexays:masterfrom
ChaosInfinited wants to merge 3 commits intoAlexays:masterfrom
Conversation
Allow selecting a hwmon device for the temperature module by its name instead of a fixed hwmon path. This avoids fragile configurations that break when new hwmon devices are added and the kernel changes hwmon ordering. The hwmon-name option is mutually exclusive with hwmon-path and hwmon-path-abs to prevent ambiguous configurations.
ChaosInfinited
changed the title
Contributor
Author
|
The nix fail seems to be coming from upstream, from cava. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the temperature module relies on hwmon paths, which can change when new devices are added or kernel driver order changes. This makes configurations fragile; for example, adding a USB device like a new gaming controller can break the CPU or GPU temperature readings.
What this PR does:
hwmon-nameoption for the temperature module.input-filenameto be set.hwmon-namecannot be used withhwmon-pathorhwmon-path-absto avoid conflicts.This provides a more stable and predictable way to configure temperature sensors, preventing breakage due to dynamic hwmon ordering.
Let me know what you think!
Kind regards.