[MNT-25404] Query Performance - High performance cost in retrieving nodes/node properties for large result sets #3631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for arm64 architecture
…odes/node properties for large result sets - Updated ResultMapper -- Added getNodes Method -- Removed HISTORY NodeStore (Never Implemented) -- Adjusted to use batch queries -- VERSIONS does not fully use this approach because of the complexity with versionhistory lookups. Needs to be addressed in the future - Added new methods across NodeService, Nodes, NodeDAO to accept Lists of NodeIds and NodeRefs. - In all but one case, there were exising SQL Queries for looking up Nodes using IN over equals - There are places still where single value lookups are made. In most cases, the values should be cached by the time these lookups are executed or these are error/exception handling cases.
…odes/node properties for large result sets - Add getAspects(List<NodeReg>) to the NodeService interface
…odes/node properties for large result sets - Add missing getAspects Method to VirtualNodeServiceExtensionImpl, NodeServiceImpl, and Node2ServiceImpl - And pre-commit changes
…odes/node properties for large result sets -pre-commit updates -Temp ignore test. Is it still valid?
…odes/node properties for large result sets - Clarify why the test is now disabled
…odes/node properties for large result sets - pre-commit changes
jottley
requested review from
Copilot,
evasques and
tiagosalvado10
and removed request for
tiagosalvado10
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 103 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
repository/src/main/java/org/alfresco/repo/cache/lookup/EntityLookupCache.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/alfresco/repo/domain/node/ibatis/NodeDAOImpl.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/alfresco/repo/domain/tenant/AbstractTenantAdminDAOImpl.java
Outdated
Show resolved
Hide resolved
remote-api/src/main/java/org/alfresco/rest/api/impl/NodesImpl.java
Outdated
Show resolved
Hide resolved
remote-api/src/main/java/org/alfresco/rest/api/search/impl/ResultMapper.java
Outdated
Show resolved
Hide resolved
…actTenantAdminDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…LookupCache.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…NodeDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Impl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Impl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Impl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…odes/node properties for large result sets - Add Null Protection
…odes/node properties for large result sets - Clean up Param name
…odes/node properties for large result sets - Clean up param name
…odes/node properties for large result sets - Clean up paramenter
…LookupCacheTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…AbstractAclCrudDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…LookupCacheTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…AbstractContentDataDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…odes/node properties for large result sets - Updates suggested by co-pilot
…odes/node properties for large result sets -Pre-Commit Cleanup
…tractEncodingDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tNodeDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tNodeDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tNodeDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tNodeDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tNodeDAOImpl.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…odes/node properties for large result sets - Pre-commit changes
Member
Author
|
Shoot me for including co-pilot on older code :-( |
Member
Author
|
Moving to another PR for these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Added getNodes Method
-- Removed HISTORY NodeStore (Never Implemented)
-- Adjusted to use batch queries
-- VERSIONS does not fully use this approach because of the complexity with versionhistory lookups. Needs to be addressed in the future