Skip to content

Remove JPB7 and fix pinouts of JPA2, JPA7, and JPB8 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 13, 2025
Merged

Remove JPB7 and fix pinouts of JPA2, JPA7, and JPB8 #63

merged 16 commits into from
May 13, 2025

Conversation

t0mpr1c3
Copy link
Contributor

Addresses #60

@t0mpr1c3 t0mpr1c3 linked an issue May 12, 2025 that may be closed by this pull request
2mm pitch 5 pin connector has wrong pinout in v1.5 #60
Closed
@t0mpr1c3 t0mpr1c3 marked this pull request as draft May 12, 2025 23:56
@t0mpr1c3 t0mpr1c3 changed the title Fix pinout of JPA7 Fix pinout of JPB8 May 12, 2025
@t0mpr1c3 t0mpr1c3 force-pushed the fix5pin branch 2 times, most recently from 92b4f48 to b207a73 Compare May 13, 2025 00:42
@t0mpr1c3 t0mpr1c3 marked this pull request as ready for review May 13, 2025 01:09
@t0mpr1c3 t0mpr1c3 force-pushed the fix5pin branch 2 times, most recently from 0389314 to 458681a Compare May 13, 2025 02:07
@t0mpr1c3 t0mpr1c3 requested review from jonathanperret and VIPQualityPost and removed request for jonathanperret May 13, 2025 02:53
@t0mpr1c3 t0mpr1c3 changed the title Fix pinout of JPB8 Remove JPB7 and fix pinouts of JPA2, JPA7, and JPB8 May 13, 2025
@t0mpr1c3 t0mpr1c3 linked an issue May 13, 2025 that may be closed by this pull request
3 pin connectors in v1.5 have wrong pinout #58
Closed
@t0mpr1c3 t0mpr1c3 self-assigned this May 13, 2025
@t0mpr1c3
Copy link
Contributor Author

This is ready to go, I'll have a look at trying to achieve a consistent orientation of the KM connectors in a separate PR.

@VIPQualityPost
Copy link
Contributor

thanks for fixing the pads to make them more uniform/hand solderable.

@t0mpr1c3 t0mpr1c3 merged commit f4bc1e1 into main May 13, 2025
@t0mpr1c3 t0mpr1c3 deleted the fix5pin branch May 13, 2025 05:53
@jonathanperret jonathanperret mentioned this pull request May 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIPQualityPost VIPQualityPost VIPQualityPost approved these changes

@jonathanperret jonathanperret Awaiting requested review from jonathanperret

Assignees

@t0mpr1c3 t0mpr1c3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2mm pitch 5 pin connector has wrong pinout in v1.5 3 pin connectors in v1.5 have wrong pinout
2 participants
@t0mpr1c3 @VIPQualityPost