Avoid spawning a subshell in -ftb-compadd
#514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subshells cause zsh to try and render their prompt. For reasons I do not entirely understand, zsh does not expand `$PROMPT` correctly in this case when PROMPT_SUBST is set. Fortunately, using a brace group instead of a subshell is simple and has the same meaning.
|
nice catch |
njhoffman
pushed a commit
to njhoffman/fzf-tab
that referenced
this pull request
May 14, 2025
Subshells cause zsh to try and render their prompt. For reasons I do not entirely understand, zsh does not expand `$PROMPT` correctly in this case when PROMPT_SUBST is set. Fortunately, using a brace group instead of a subshell is simple and has the same meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subshells cause zsh to try and render their prompt. For reasons I do not entirely understand, zsh does not expand
$PROMPTcorrectly in this case when PROMPT_SUBST is set.Fortunately, using a brace group instead of a subshell is simple and has the same meaning.
Fixes #513