Skip to content

Commit 1119b5a

Browse files
committed
fix: replace sessionStorage with session cookie
Because it was found that sessionStorage works differently from session cookie.
1 parent 498cdd7 commit 1119b5a

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

packages/npm/@amazeelabs/decap-cms-backend-token-auth/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,11 @@
4646
"devDependencies": {
4747
"@amazeelabs/eslint-config": "1.4.43",
4848
"@octokit/types": "13.5.0",
49+
"@types/js-cookie": "3.0.6",
4950
"@types/node": "18.19.33",
5051
"@types/react": "18.3.1",
5152
"@types/semaphore": "1.1.4",
53+
"js-cookie": "3.0.5",
5254
"typescript": "5.4.5",
5355
"vitest": "1.6.0"
5456
},

packages/npm/@amazeelabs/decap-cms-backend-token-auth/src/backend.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TokenAuthClient } from '@amazeelabs/token-auth-middleware';
22
import { GitHubBackend } from 'decap-cms-backend-github';
33
import { Implementation } from 'decap-cms-lib-util';
4+
import Cookies from 'js-cookie';
45

56
import { AuthComponent } from './ui.js';
67

@@ -55,7 +56,7 @@ export class TokenAuthBackend implements Implementation {
5556
// Authenticate against the delegate backend.
5657
await this.delegate.authenticate(status);
5758
// Let frontend know that user is logged in.
58-
sessionStorage.setItem('decap-cms-logged-in', '1');
59+
Cookies.set('decap-cms-logged-in', '1');
5960
// Return status information.
6061
return {
6162
...status,
@@ -81,7 +82,7 @@ export class TokenAuthBackend implements Implementation {
8182
async logout() {
8283
await this.client.logout();
8384
await this.delegate.logout();
84-
sessionStorage.removeItem('decap-cms-logged-in');
85+
Cookies.remove('decap-cms-logged-in');
8586
}
8687

8788
/**

pnpm-lock.yaml

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)