Skip to content

refactor(SLB-458): consolidate qr generation #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

refactor(SLB-458): consolidate qr generation #1568

merged 1 commit into from
Aug 15, 2024
+27 −7

Conversation

colorfield
Copy link
Member

Package(s) involved

silverback_preview_link

Description of changes

  • Fix an issue with base64_encode
  • Progressive degradation instead of fatal error so the copy link feature is still available
  • Log if the branded QR fails to generate and fallback to a generic QR
  • Log and display a short message on the UI if the generic QR fails to generate

How has this been tested?

Manually.

@colorfield colorfield merged commit 8f9913f into development Aug 15, 2024
3 checks passed
@colorfield colorfield deleted the SLB-458-consolidate-qr-generation branch August 15, 2024 10:46
@colorfield colorfield mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colorfield