chore(publisher): improve state error message #1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package(s) involved
publisherDescription of changes
Better error message for potential Consumer related error.
Motivation and context
Consumers are content entities.
After syncing a DB, we inherit the entity from the source database, which will yield the vague State does not match. error message that can be confusing and hard to debug.
As this message is very unlikely to be exposed to regular end users (it's mostly a security measure), this simple fix should be good enough.
Related Issue(s)
AmazeeLabs/silverback-template#533
How has this been tested?
Manually.