(test) (fix) fix failing tests, update newsspaper.hot/google trends rss feed#665
Open
BRNMan wants to merge 2 commits intoAndyTheFactory:masterfrom
Open
(test) (fix) fix failing tests, update newsspaper.hot/google trends rss feed#665BRNMan wants to merge 2 commits intoAndyTheFactory:masterfrom
BRNMan wants to merge 2 commits intoAndyTheFactory:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
N/A
Proposed Changes:
A few tests were failing due to websites updating or going down. I fixed them and added an updated link to google trends for newspaper.hot().
How did you test it?
Ran the tests again. Ran newspaper.hot() and checked output.
Notes for the reviewer
I didn't fix the gnews test because it confused me and discovered an issue with category parsing that popped up in test_source which I will document under issues.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.