Skip to content

Conversation

johnson2427
Copy link
Contributor

@johnson2427 johnson2427 commented Aug 20, 2024

What I did

Added ape slim to the build process and then created a build yaml to deploy our image to ghcr

fixes: #71
fixes: SBK-429

How I did it

Confirmed I can build locally with the ape slim image, then reused a bit of ape's build process

How to verify it

run docker build locally with a locally built ape-slim container

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

fubuloubu
fubuloubu previously approved these changes Aug 20, 2024
@johnson2427
Copy link
Contributor Author

Do not merge this, testing that the workflow works, then I have to fix ape's image deployment

Copy link

linear bot commented Aug 21, 2024

@johnson2427 johnson2427 enabled auto-merge (squash) August 24, 2024 01:11
@johnson2427 johnson2427 requested a review from fubuloubu August 26, 2024 14:06
@fubuloubu
Copy link
Member

Perfect

This PR is blocked until release of Ape (and verifying ape stable-slim is properly being built)

@fubuloubu fubuloubu disabled auto-merge September 23, 2024 23:47
@fubuloubu
Copy link
Member

Stable slim is not getting published...

@johnson2427 johnson2427 force-pushed the feat/docker-image-build-update branch from 02f53de to 1a037b7 Compare September 30, 2024 18:02
@johnson2427
Copy link
Contributor Author

@fubuloubu let me know how far back we want to keep containers. I have the same policy as ape right now for retention, I'm sure we don't want that

@fubuloubu
Copy link
Member

@fubuloubu let me know how far back we want to keep containers. I have the same policy as ape right now for retention, I'm sure we don't want that

I think just until 0.5.0, because that's is the minimum that the clusters support

fubuloubu
fubuloubu previously approved these changes Sep 30, 2024
@johnson2427 johnson2427 merged commit 4d6c75c into main Sep 30, 2024
22 checks passed
@johnson2427 johnson2427 deleted the feat/docker-image-build-update branch September 30, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use GHCR instead of Dockerhub
2 participants