Skip to content

test: max type was off in the test #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

test: max type was off in the test #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a847501
test: max type was off
antazoey Sep 18, 2024
b128ee5
test: other test
antazoey Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
({"a": 1}, {"a": {"type": "scalar", "data": 1}}),
# max INT96 value
(
{"a": 2**96 - 1},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were maybe thinkin' of UInt96 here?

{"a": {"type": "scalar", "data": 79228162514264337593543950335}},
{"a": 2**95 - 1},
{"a": {"type": "scalar", "data": 39614081257132168796771975167}},
),
# int over INT96 max parses as Decimal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also doesn't match

(
{"a": 2**96},
{"a": {"type": "scalar", "data": Decimal("79228162514264337593543950336")}},
{"a": 2**95},
{"a": {"type": "scalar", "data": Decimal("39614081257132168796771975168")}},
),
# Decimal parses as Decimal
(
Expand Down
Loading