Skip to content

fix: warn the user (instead of DEBUG) log when runtime exit #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: warn the user (instead of DEBUG) log when runtime exit #125

merged 1 commit into from
Oct 1, 2024

Conversation

fubuloubu
Copy link
Member

@fubuloubu fubuloubu commented Oct 1, 2024 •
edited
Loading

What I did

fixes: #124

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu enabled auto-merge (squash) October 1, 2024 22:36
@fubuloubu fubuloubu requested a review from mikeshultz October 1, 2024 22:36
@fubuloubu fubuloubu merged commit 13b843f into main Oct 1, 2024
22 checks passed
@fubuloubu fubuloubu deleted the fix/warn-on-runtime-exit branch October 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikeshultz mikeshultz mikeshultz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Critical errors are not raised, impossible to see if there's an error
2 participants
@fubuloubu @mikeshultz