feat: support multi-source logs #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In draft until ApeWorX/ape-tokens#55 lands so that example works |
antazoey
approved these changes
May 5, 2025
| self.poll_settings[key] = {"new_block_timeout": new_block_timeout} | ||
|
|
||
| if start_block is not None: | ||
| if key in self.poll_settings: |
There was a problem hiding this comment.
style: Several spots can be cleaned up using .setdefault(), e.g.:
self.poll_settings.setdefault(key, {})
self.poll_settings[key]["start_block"] = start_block
There was a problem hiding this comment.
tbh I've been trying to migrate this code into Ape, into new ProviderAPI.aiter_logs/ProviderAPI.aiter_blocks methods that can go figure out how to configure using websocket or http polling based on how it is configured to operate (if it has websockets/IPC or not). Then I can consolidate the WebsocketRunner and PollingRunner classes into one LiveRunner class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adds support to silverback for event logs from any source
fixes: #99
How I did it
How to verify it
Requires ApeWorX/ape-tokens#55 to test example
Checklist