Skip to content

Conversation

fubuloubu
Copy link
Member

What I did

Noticed that if you are working with a more complex monorepo-style project where the bots are intended to build different than the rest of the project, that having a pyproject.toml present causes a big issues.

This PR allows side-stepping the issue by specifying either requirements.txt or requirements-bot.txt (the later takes precedence), while still letting ape install plugins found in pyproject.toml.

Additionally, I added a few more features to the docker build wrapper so it can produce tagged images natively, and added a push flag to silverback build. This actually should make it nicer to build for local use as well as for upcoming cluster registry direct push feature (that I still need to define)

Lastly, I more fully documented silverback build

How I did it

How to verify it

Try some commands

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu
Copy link
Member Author

p.s. I think that the build CI here will fail until it's released, due to how it's built

wonder if work on SilverbackLtd/build-action#5 could fix this...

fubuloubu added a commit to SilverbackLtd/build-action that referenced this pull request May 15, 2025
fubuloubu added a commit to SilverbackLtd/build-action that referenced this pull request May 15, 2025
johnson2427
johnson2427 previously approved these changes May 15, 2025
Copy link
Contributor

@johnson2427 johnson2427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this locally, LGTM

I'll approve so you can move forward while I attempt to make a more complicated monorepo to stress this

fubuloubu added a commit to SilverbackLtd/build-action that referenced this pull request May 15, 2025
@fubuloubu fubuloubu merged commit 1d52f85 into main May 15, 2025
27 checks passed
@fubuloubu fubuloubu deleted the fix/build/setuptools-scm-version branch May 15, 2025 18:28
@fubuloubu fubuloubu restored the fix/build/setuptools-scm-version branch May 15, 2025 18:31
@fubuloubu
Copy link
Member Author

Temporarily restoring branch here, so CI can pass (until build-action is updated

@fubuloubu
Copy link
Member Author

Okay, updated in SilverbackLtd/build-action#7

@fubuloubu fubuloubu deleted the fix/build/setuptools-scm-version branch May 15, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants