-
-
Notifications
You must be signed in to change notification settings - Fork 14
fix(build): workaround for pyproject.toml
build bug
#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also added documentation for these flags and `--generate`
p.s. I think that the build CI here will fail until it's released, due to how it's built wonder if work on SilverbackLtd/build-action#5 could fix this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this locally, LGTM
I'll approve so you can move forward while I attempt to make a more complicated monorepo to stress this
Temporarily restoring branch here, so CI can pass (until |
Okay, updated in SilverbackLtd/build-action#7 |
What I did
Noticed that if you are working with a more complex monorepo-style project where the bots are intended to build different than the rest of the project, that having a
pyproject.toml
present causes a big issues.This PR allows side-stepping the issue by specifying either
requirements.txt
orrequirements-bot.txt
(the later takes precedence), while still letting ape install plugins found inpyproject.toml
.Additionally, I added a few more features to the
docker build
wrapper so it can produce tagged images natively, and added a push flag tosilverback build
. This actually should make it nicer to build for local use as well as for upcoming cluster registry direct push feature (that I still need to define)Lastly, I more fully documented
silverback build
How I did it
How to verify it
Try some commands
Checklist