feat: implement faster-eth-utils #266
Conversation
| @@ -13,7 +13,7 @@ | |||
| from ape import chain | |||
| from ape.logging import logger | |||
| from ape.utils import ManagerAccessMixin | |||
| from eth_utils import to_checksum_address | |||
| from cchecksum import to_checksum_address | |||
There was a problem hiding this comment.
wouldn't it make sense to re-export this via your package? (to maintain compatibility)
There was a problem hiding this comment.
Yeah that's a good idea but it isn't currently implemented and I have a bit of a pile in front of me to work thru first. Up to you how to handle it here for the time being. The faster implementation is still faster, just less magnitude of difference.
There was a problem hiding this comment.
The most recent faster-eth-utils now uses the implementation from cchecksum
So it depends on how tight you'd like the pin to be
|
Overall, what platforms/architectures does this new package support? |
|
It supports all CPython distros >= 3.8 |
|
Just # type: ignore'd the type error. |
oof, needs |
|
done |
|
bro what? evidently we can't have a type: ignore and a noqa: on the same line should we just break up that line? |
What I did
This PR implements faster-eth-utils, my faster fork of eth-utils.
Benchmarks are available here.
Checklist