fix: enable password manager autofill for all password fields #8295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added autofillHints to password fields in sign-in, password setup, and password change screens - Enables password managers (1Password, LastPass, Bitwarden, etc.) to detect and autofill password fields - Minimal change: only added AutofillHints.password property to 8 password fields across 4 files
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds AutofillHints.password to all password input fields across sign-in and account settings screens to enable password manager detection and autofill. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/continue_with/set_new_password.dart:148` </location>
<code_context>
hintText: LocaleKeys.signIn_enterPassword.tr(),
autoFocus: true,
obscureText: true,
+ autofillHints: const [AutofillHints.password],
suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
</code_context>
<issue_to_address>
**suggestion:** Use AutofillHints.newPassword for new password entry fields.
AutofillHints.newPassword should be used here to indicate a password creation field, improving compatibility with password managers.
</issue_to_address>
### Comment 2
<location> `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/password/setup_password.dart:139` </location>
<code_context>
hintText: LocaleKeys.signIn_enterPassword.tr(),
autoFocus: true,
obscureText: true,
+ autofillHints: const [AutofillHints.password],
suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
</code_context>
<issue_to_address>
**suggestion:** Switch to AutofillHints.newPassword for password setup fields.
Use AutofillHints.newPassword for both password and confirm password fields during password setup to improve autofill functionality.
Suggested implementation:
```
autofillHints: const [AutofillHints.newPassword],
```
```
autofillHints: const [AutofillHints.newPassword],
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| key: newPasswordKey, | ||
| controller: newPasswordController, | ||
| obscureText: true, | ||
| autofillHints: const [AutofillHints.password], |
There was a problem hiding this comment.
suggestion: Use AutofillHints.newPassword for new password entry fields.
AutofillHints.newPassword should be used here to indicate a password creation field, improving compatibility with password managers.
| .tr(), | ||
| keyboardType: TextInputType.visiblePassword, | ||
| obscureText: true, | ||
| autofillHints: const [AutofillHints.password], |
There was a problem hiding this comment.
suggestion: Switch to AutofillHints.newPassword for password setup fields.
Use AutofillHints.newPassword for both password and confirm password fields during password setup to improve autofill functionality.
Suggested implementation:
autofillHints: const [AutofillHints.newPassword],
autofillHints: const [AutofillHints.newPassword],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8293
Feature Preview
PR Checklist
Summary by Sourcery
Enhancements: