Skip to content

fix: enable password manager autofill for all password fields #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix: enable password manager autofill for all password fields #8295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...resentation/screens/sign_in_screen/widgets/continue_with/continue_with_password_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ class _ContinueWithPasswordPageState extends State<ContinueWithPasswordPage> {
hintText: LocaleKeys.signIn_enterPassword.tr(),
autoFocus: true,
obscureText: true,
autofillHints: const [AutofillHints.password],
suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
height: iconSize,
Expand Down
2 changes: 2 additions & 0 deletions .../lib/user/presentation/screens/sign_in_screen/widgets/continue_with/set_new_password.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ class _SetNewPasswordWidgetState extends State<SetNewPasswordWidget> {
key: newPasswordKey,
controller: newPasswordController,
obscureText: true,
autofillHints: const [AutofillHints.password],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Use AutofillHints.newPassword for new password entry fields.

AutofillHints.newPassword should be used here to indicate a password creation field, improving compatibility with password managers.

hintText: LocaleKeys.signIn_enterNewPassword.tr(),
onSubmitted: (_) => _validateAndSubmit(),
),
Expand All @@ -160,6 +161,7 @@ class _SetNewPasswordWidgetState extends State<SetNewPasswordWidget> {
key: confirmPasswordKey,
controller: confirmPasswordController,
obscureText: true,
autofillHints: const [AutofillHints.password],
hintText: LocaleKeys.signIn_confirmNewPassword.tr(),
onSubmitted: (_) => _validateAndSubmit(),
),
Expand Down
3 changes: 3 additions & 0 deletions ...y_flutter/lib/workspace/presentation/settings/pages/account/password/change_password.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ class _ChangePasswordDialogContentState
.tr(),
keyboardType: TextInputType.visiblePassword,
obscureText: true,
autofillHints: const [AutofillHints.password],
suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
height: iconSize,
Expand Down Expand Up @@ -173,6 +174,7 @@ class _ChangePasswordDialogContentState
.tr(),
keyboardType: TextInputType.visiblePassword,
obscureText: true,
autofillHints: const [AutofillHints.password],
suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
height: iconSize,
Expand Down Expand Up @@ -205,6 +207,7 @@ class _ChangePasswordDialogContentState
.tr(),
keyboardType: TextInputType.visiblePassword,
obscureText: true,
autofillHints: const [AutofillHints.password],
suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
height: iconSize,
Expand Down
2 changes: 2 additions & 0 deletions ...wy_flutter/lib/workspace/presentation/settings/pages/account/password/setup_password.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ class _SetupPasswordDialogContentState
.tr(),
keyboardType: TextInputType.visiblePassword,
obscureText: true,
autofillHints: const [AutofillHints.password],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Switch to AutofillHints.newPassword for password setup fields.

Use AutofillHints.newPassword for both password and confirm password fields during password setup to improve autofill functionality.

Suggested implementation:

        autofillHints: const [AutofillHints.newPassword],


        autofillHints: const [AutofillHints.newPassword],

suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
height: iconSize,
Expand Down Expand Up @@ -168,6 +169,7 @@ class _SetupPasswordDialogContentState
.tr(),
keyboardType: TextInputType.visiblePassword,
obscureText: true,
autofillHints: const [AutofillHints.password],
suffixIconConstraints: BoxConstraints.tightFor(
width: iconSize + theme.spacing.m,
height: iconSize,
Expand Down