Skip to content

Release Python Global Interpreter Lock During Detection #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Release Python Global Interpreter Lock During Detection #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apriltag_pywrap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,11 @@ static PyObject* apriltag_detect(apriltag_py_t* self,
.stride = strides[0],
.buf = PyArray_DATA(image)};

zarray_t* detections = apriltag_detector_detect(self->td, &im);
zarray_t *detections; // Declare detections variable outside of the GIL block
Py_BEGIN_ALLOW_THREADS // Acquire the GIL before running detection
detections = apriltag_detector_detect(self->td, &im);
Py_END_ALLOW_THREADS // Release the GIL after detection completes

int N = zarray_size(detections);

if (N == 0 && errno == EAGAIN){
Expand Down
Loading