Skip to content

Conversation

andstor
Copy link
Contributor

@andstor andstor commented Aug 8, 2025

Instrumentation of smolagents are not handling the LLM input messages properly anymore. This PR should fix it.

@andstor andstor requested a review from a team as a code owner August 8, 2025 07:38
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 8, 2025
cursor[bot]

This comment was marked as outdated.

@axiomofjoy axiomofjoy self-requested a review August 8, 2025 15:11
@axiomofjoy axiomofjoy changed the title fix(smolagents): Fix missing llm input messages in smolagents fix(smolagents): fix missing llm input messages in smolagents and prevent duplicate llm spans Aug 22, 2025
@axiomofjoy axiomofjoy changed the title fix(smolagents): fix missing llm input messages in smolagents and prevent duplicate llm spans fix(smolagents): fix missing llm input messages in smolagents Aug 22, 2025
@axiomofjoy
Copy link
Contributor

Hey @andstor, I am not able to reproduce the issue you were hitting on the latest version of the instrumentation and smolagents==1.21.2. Perhaps the issue has been resolved?

@andstor
Copy link
Contributor Author

andstor commented Aug 24, 2025

Hey @andstor, I am not able to reproduce the issue you were hitting on the latest version of the instrumentation and smolagents==1.21.2. Perhaps the issue has been resolved?

Hi @axiomofjoy, I just did the same check and the problem persists. I opened an issue to showcase the problem #2125.

@axiomofjoy
Copy link
Contributor

Thanks @andstor. Do you have a small code snippet to reproduce the issue?

@axiomofjoy
Copy link
Contributor

Hey @andstor, it looks like this change causes our existing TestModels tests to break. The issue seems to be that the models used in those tests have messages in dictionary format rather than the smolagents.models.ChatMessage format in the snippet you sent here.

I think it will be necessary to support both formats, and tests are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs information size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants