Skip to content

Conversation

GeLi2001
Copy link
Contributor

@GeLi2001 GeLi2001 commented Aug 12, 2025

resolves #1392

Screenshot 2025-08-28 at 4 21 19 PM

@GeLi2001 GeLi2001 requested a review from a team as a code owner August 12, 2025 19:15
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 12, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 12, 2025
Copy link

pkg-pr-new bot commented Aug 12, 2025

Open in StackBlitz

@arizeai/openinference-core

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-core@2085

@arizeai/openinference-instrumentation-bedrock

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-bedrock@2085

@arizeai/openinference-instrumentation-bedrock-agent-runtime

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-bedrock-agent-runtime@2085

@arizeai/openinference-instrumentation-beeai

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-beeai@2085

@arizeai/openinference-instrumentation-langchain

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-langchain@2085

@arizeai/openinference-instrumentation-mcp

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-mcp@2085

@arizeai/openinference-instrumentation-openai

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-instrumentation-openai@2085

@arizeai/openinference-mastra

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-mastra@2085

@arizeai/openinference-semantic-conventions

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-semantic-conventions@2085

@arizeai/openinference-vercel

npm i https://pkg.pr.new/Arize-ai/openinference/@arizeai/openinference-vercel@2085

commit: d4f3297

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@Arize-ai Arize-ai deleted a comment from cursor bot Aug 12, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@caroger caroger requested a review from RogerHYang August 21, 2025 17:01
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@axiomofjoy
Copy link
Contributor

Probably worth a unit test.

- Extract url.full with complete URL
- Extract url.path with deployment info (deployments/model-name/endpoint)
- Improve Azure provider detection
- Add unit test for URL extraction functionality
@GeLi2001
Copy link
Contributor Author

GeLi2001 commented Sep 5, 2025

Probably worth a unit test.

agree, added a simple test

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Streaming Chat Missing URL Attributes

Streaming chat completion spans are missing URL attributes, unlike their non-streaming counterparts. This occurs because getStoredUrlAttributes isn't called when processing streaming responses, leading to inconsistent debugging information.

js/packages/openinference-instrumentation-openai/src/instrumentation.ts#L541-L548

} else {
// This is a streaming response
// handle the chunks and add them to the span
// First split the stream via tee
const [leftStream, rightStream] = result.tee();
consumeChatCompletionStreamChunks(rightStream, span);
result = leftStream;
}

Fix in Cursor Fix in Web


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

capture url path in openinference openai instrumentor
2 participants