fix: CI issues for openai agents #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
satyadevai
force-pushed
the
cannary-cron-ci-issues
branch
2 times, most recently
from
6d75c8d to
def0286
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
satyadevai
force-pushed
the
cannary-cron-ci-issues
branch
from
b9f4e97 to
5812f7b
Compare
satyadevai
changed the title
caroger
reviewed
Oct 28, 2025
python/instrumentation/openinference-instrumentation-agno/tests/test_instrumentor.py
Outdated
Show resolved
Hide resolved
caroger
reviewed
Oct 28, 2025
caroger
reviewed
Oct 28, 2025
...-instrumentation-openai-agents/src/openinference/instrumentation/openai_agents/_processor.py
Outdated
Show resolved
Hide resolved
satyadevai
force-pushed
the
cannary-cron-ci-issues
branch
from
5812f7b to
8d2e2ad
Compare
satyadevai
changed the title
caroger
reviewed
Oct 30, 2025
| yield f"{prefix}{MESSAGE_CONTENT}", obj["output"] | ||
| # output can be str or complex type - serialize complex types to JSON | ||
| if output := obj.get("output"): | ||
| output_value = output if isinstance(output, str) else safe_json_dumps(output) |
Collaborator
There was a problem hiding this comment.
do a type check here instead of runtime check.
assert never
dosubot
bot
added
size:M
satyadevai
commented
Nov 3, 2025
| for i, item in enumerate(output): | ||
| if item["type"] == "input_text": | ||
| yield ( | ||
| f"{prefix}{MESSAGE_CONTENTS}.{i}.{MESSAGE_CONTENT_TEXT}", |
Collaborator
Author
There was a problem hiding this comment.
@caroger, could you please confirm whether the attribute name is correct?. Based on my understanding, FunctionCallOutput can contain either a string or a List[Union[ResponseInputTextContentParam, ResponseInputImageContentParam, ResponseInputFileContentParam]]. I’ve assumed it will be a list of contents, so I’m passing these values as contents.
caroger
approved these changes
Nov 13, 2025
Merged
axiomofjoy
added a commit
to codefromthecrypt/openinference
that referenced
this pull request
Nov 21, 2025
This reverts commit a18078b.
axiomofjoy
added a commit
that referenced
this pull request
Nov 21, 2025
This reverts commit a18078b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2376
Note
Handle
outputas string or list for tool/function call outputs, extractinginput_textintomessage.contents.*.message_content.text; update tests accordingly./_processor.pyto parse tool/function calloutputas eitherstrorlist.input_textitems intomessage.contents.{i}.message_content.text.input_imageandinput_filetypes.tests/test_span_attribute_helpers.py.Written by Cursor Bugbot for commit 96af527. This will update automatically on new commits. Configure here.