Skip to content

Conversation

@codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Nov 12, 2025

Remove hardcoded constant and outdated TODO comment. Use the official SpanAttributes.EMBEDDING_INVOCATION_PARAMETERS constant that was released in semantic conventions v0.1.25.

Bump openinference-semantic-conventions from >=0.1.23 to >=0.1.25.


Note

Serialize non-string tool/function outputs to JSON for agents and switch embeddings attribute to the official SpanAttributes constant, with dependency bump and minor mypy config tweak.

  • OpenAI Agents Instrumentation:
    • JSON-serialize non-string output values for custom_tool_call_output and function_call_output; skip emitting content when output is None.
    • Expand tests to cover string, list, and dict outputs for both paths.
    • Mypy: add per-test override to disable warn_unused_ignores due to OpenAI type version differences.
  • OpenAI Instrumentation:
    • Replace custom embedding invocation parameter key with SpanAttributes.EMBEDDING_INVOCATION_PARAMETERS.
    • Bump openinference-semantic-conventions to >=0.1.25.

Written by Cursor Bugbot for commit 87bdaa8. This will update automatically on new commits. Configure here.

Remove hardcoded constant and outdated TODO comment. Use the official
SpanAttributes.EMBEDDING_INVOCATION_PARAMETERS constant that was
released in semantic conventions v0.1.25.

Bump openinference-semantic-conventions from >=0.1.23 to >=0.1.25.
@codefromthecrypt codefromthecrypt force-pushed the chore/openai-semconv-cleanup branch from 35592bb to a83c407 Compare November 13, 2025 13:31
@codefromthecrypt codefromthecrypt marked this pull request as ready for review November 13, 2025 13:41
@codefromthecrypt codefromthecrypt requested a review from a team as a code owner November 13, 2025 13:41
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 13, 2025
…uteValue compatibility

Handle edge cases where FunctionCallOutput and ResponseCustomToolCallOutputParam contain complex output types (lists, dicts) that don't match AttributeValue type. Serialize these to JSON strings while preserving None and string values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant