Fix several problems in OpenHardwareMonitor plugin #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `SensorType` was missing the `Conductivity` variant. - Better use `Enum.TryParse` to parse the `SensorType`, every unknown variant now defaults to `Other`. - Fetch the WMI to check if the classes have been initialized correctly instead of using `Thread.Sleep`.
Bergmann89
force-pushed
the
fix-open-hardware-monitor
branch
from
5ca743d to
bac5062
Compare
|
I haven't had time to look at this lately, poking myself again so I don't forget. Sorry 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced several problems when using the OpenHardwareMonitor plugin in my environment. I've implemented several fixed for all problems I have noticed:
SensorTypewas missing theConductivityvariant.Enum.TryParseto parse theSensorType, every unknown variant now defaults toOther.Thread.Sleep.