Skip to content

Commit 181c295

Browse files
authored
feat: added recommendations for html-css-popup task (kottans#317)
* feat: added recommendations for html-css-popup task * fix: updated visually-hidden styles * fix: updated recommendations * fix: updated description for the empty line * fix: updated styling elements recommendation
1 parent 5e430f2 commit 181c295

File tree

1 file changed

+24
-7
lines changed

1 file changed

+24
-7
lines changed

tasks/html-css-popup.md

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,40 @@
88
> **Hooli** is a fictitious corporation from
99
> [Silicon Valley TV series](https://www.imdb.com/title/tt2575988/).
1010
> Many believe it impersonates Google or Apple.
11-
> Hooli on [Silicon Valley famdom wiki](https://silicon-valley.fandom.com/wiki/Hooli).
11+
> Hooli on [Silicon Valley famdom wiki](https://silicon-valley.fandom.com/wiki/Hooli).
1212
> It is also represented [on the web](http://www.hooli.xyz/).
13-
13+
1414
The goal of this task is to practice coding HTML & CSS from mockup. You are expected to deepen your knowledge of HTML & CSS and discover new previously unknown features.
1515

1616
## Requirements
17+
1718
- no JavaScript, only HTML/CSS, use of preprocessors is allowed
1819
- no external libraries or frameworks
1920
- browser support: Chrome only (feel free to use latest features)
2021
- the popup is expected to have three states depending on user actions:
2122
- initial state: popup menu is not visible
22-
- upon click on ![popup-button](../img/popup-button.png) button
23-
the popup menu gets visible or gets hidden if already open
24-
- click on "More" button adds 3 to 10 more icons and
23+
- upon click on ![popup-button](../img/popup-button.png) button
24+
the popup menu gets visible or gets hidden if already open
25+
- click on "More" button adds 3 to 10 more icons and
2526
makes the content of the popup scrollable
2627
- mobile view is irrelevant for this task
2728

29+
## Recommendations
30+
31+
- Make sure that your navigation is built with all semantic [rules](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/nav).
32+
- We recommend watching a [video](https://www.youtube.com/watch?v=E6kLaaQFctU&ab_channel=VadimMakeev) about hiding checkbox good parts.
33+
- Try to style your elements by classes (not by ID and HTML tags).
34+
- Don't forget to set the `alt` attribute for the `img` tags (if you used them).
35+
- No need to add a lot of files (inc. icons, gitignore, configs, etc) to your PR. HTML and CSS files would be enough for checking your work.
36+
- Avoid external scripts for the font icons.
37+
- Check your preview in the [validator](https://validator.w3.org/).
38+
- Make sure you've added empty lines in each file from your PR - [reason](https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline).
39+
If you forget to add an empty line at the end of the file GitHub will show it:
40+
41+
![Missed line](https://user-images.githubusercontent.com/16196199/97906688-c123c900-1d4c-11eb-8424-75e9150b0705.png)
42+
43+
- Check your work again and remove all redundant comments from your code.
44+
2845
## Warning
2946

3047
:warning: ![Google-Warning](https://place-hold.it/380x24/fff/f03c15?text=Important!+Google+may+ban+your+github+pages+domain!&bold)
@@ -34,6 +51,7 @@ as they may decide that you've created a phishing site to steal
3451
your visitors' Google credentials.
3552

3653
To avoid this
54+
3755
- DO NOT use word "google", "apple", "amazon" or any other brand in
3856
- your project/repo name
3957
- any urls
@@ -76,6 +94,7 @@ You may want to publish your results on
7694
[GitHub Pages](https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/)
7795

7896
**When complete do the following:**
97+
7998
1. You will require code review for this task:
8099
- For **Frontend 2021** course students: please, follow [these instructions](https://github.com/kottans/frontend-2021-homeworks/blob/master/README.md)
81100
- For **p2p course** students: please, follow [these instructions](https://github.com/kottans/frontend-2019-p2p/blob/master/CONTRIBUTING.md)
@@ -89,11 +108,9 @@ You may want to publish your results on
89108

90109
⤴️ Back to [Contents](../contents.md)
91110

92-
93111
[icon-chat]: https://img.shields.io/badge/chat-on%20telegram-blue.svg
94112
[icon-mit]: https://img.shields.io/badge/license-MIT-blue.svg
95113
[icon-awesome]: https://cdn.rawgit.com/sindresorhus/awesome/d7305f38d29fed78fa85652e3a63e154dd8e8829/media/badge.svg
96-
97114
[license]: https://github.com/Kottans/web/blob/master/LICENSE.md
98115
[awesome]: https://github.com/sindresorhus/awesome#front-end-development
99116
[chat]: https://t.me/joinchat/CX8EF1JmLm9IM6J6oy2U7Q

0 commit comments

Comments
 (0)