FEAT: add skeleton for amico implementation#89
Open
matteofrigo wants to merge 31 commits into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we add the skeleton for the implementation of AMICO. Let's open the discussion @Sara04 @rutgerfick .
dmipy.core.modeling_frameworkFor the MultiCompartmentAMICOModel and the MultiCompartmentAMICOSphericalMeanModel we have to do the following:
_create_forward_model_matrixfitfunctionfitfunction, taking into account that the look-up table must be built or loaded.fit_funcmethod in thefitfunctionx0as required by the solverdmipy.core.fitted_modeling_frameworkfitted_distributionproperty to the FittedMultiCompartmentAMICOModel and FittedMultiCompartmentAMICOSphericalMeanModel classes. This is intended to return the distribution of each parameter obtained from the AMICO fitting.fitted_parameterproperty could be built on top of thefitted_distribution.