Missing gain import when using the AutoEQ database

[randshell]

Hi,

first, thank you for this amazing project!

I'd like to report a bug / improvement that affects the AutoEQ feature on the Graphic EQ tab. This import updates the EQ graphic, but it does not change the post gain to a negative value. This instruction can be found on the AutoEQ project when visited directly.

For example, on this result the recommended pre-amp is of -6.4dB. Without this negative gain, so just by importing the AutoEQ result from the database, I've found for some frequencies to be more distorted, which I've noted especially in the bass.

As a solution, I'd like to suggest to either import automatically the post gain / preamp and set it in the Bass/Misc > Limiter/Master tab or, otherwise, to inform the user about manually setting the gain value.

[dagelf]

...and looks like autoeq download is completely broken on jamesdsp 2.7.0-0-g30a30aa (Pipewire flavor) at least as of right now... it downloads, but never finishes "decompressing package"

[dagelf]

Here's the code that downloads the DB https://github.com/Audio4Linux/JDSP4Linux/blob/master/src/subprojects/AutoEqIntegration/AeqPackageManager.cpp#L13

Gets it from https://raw.githubusercontent.com/ThePBone/AutoEqPackages/main/archive.tar.gz on https://github.com/timschneeb/AutoEqPackages

Which is 12672 directories, 12958 files, mostly txt and csv

autoeq]$ find . -name \*json
./version.json
./index.json

If you download and extract it, you can import from the Graphic EQ page and browse to the csv file in a certain directory. Doesn't sound like an automatic gain is applied off the bat.

So... my first time looking at any of this including AutoEQ. These look like they're merely the inputs to AutoEQ... the csv's don't seem to contain a gain. So these files look like they still need to be processed by AutoEQ to calculate the gain, or that calculation needs to be built into JamesDSP.

Tell me if I'm wrong...

Anyways, besides that, clearly the strategy of pulling an archive from what looks like an orphan github repo, isn't the best idea. AutoEQ should have an official downstream way (or upstream?) way to get the configurations.

If I compare these files to the files downloaded from https://autoeq.app/ (same description) I don't see a correlation. So I'm guessing JamesDSP includes AutoEQ and processes it locally.

[dagelf]

If you go to https://autoeq.app and you choose EqualizerAPO and use the Import EqualizerAPO button, it seems to import the AutoEQ corrected profiles. But it looks like the Graphic EQ module doesn't have gain, so not sure if JamesDSP has a hook to apply it. I guess it could just subtract the average from each band, that should have the same effect, only difference is that it won't be easily adjustable on JamesDSP.