fix volume reset when unmuting by clicking the slider #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zWolfrost
changed the title
zWolfrost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
This happened because when "set_muted" is called to unmute a meter, it checks if the volume is 0% on both sides and resets them to 100% if it is.
However, the volume it got was under some kind of latency and, when unmuting by clicking the slider, "set_muted" still thinks the volume is 0% (from both sides), thus resetting the volume to 100% anyway.
By setting the variable "zero_volume_reset" i have made sure that the volume is not reset when unmuting by clicking the slider, but only when clicking the button directly.