Fixes Odyssey maps spawning outside of its gamemode #21305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To break down the way we handle map spawning logic:
in
mapsystem/map.dm
,build_away_sites()
evaluates every map_template and organizes suitable candidates considering: flags they bear, if the current sector allows this away site to spawn, etc...It randomly picks among available maps via
pickweight()
, decreasing relevant cost from the total budgetSo far why this never caused any problems is,
pickweight()
will never pick a key with 0 value unless every key passed to this function has 0 value. What was happening here is system runs out of other candidates before exhausting its budget, leaving only odyssey maps with 0 weight in the list.This fix should only affect natural map spawning process, since Odyssey has its own method on choosing candidates. Fixes #21276