-
Notifications
You must be signed in to change notification settings - Fork 551
Sol Passcards #21479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sol Passcards #21479
Conversation
!review |
Hold up there's some issues I still need to correct. |
going to copypaste my feedback from discord discussion here
hate to say it but im afraid im not for this one. im not a spriter though so im going purely vibes based here |
I would like to add that these sprites have been, mostly, completed for about a year or so. I held back from having them PRed due to feedback similar to what has been expressed above. However, this PR came as a result of the Human Lore Team explicitly requesting these sprites, reviewing them, approving both them and their descriptions, and requesting that I PR them. They have explicitly stated they do not want 'unique', 'flashy' passcards, as they clash with Solarian Lore in regards to the degree of centralization. I'll admit that my sprites do lose some quirkiness compared to the existing ones they replace, however I think it's important to realize that they're what they are, government issued ID cards. Government issued ID cards are not quirky, memorable, or flashy in the way that some of the existing ones are, particularly Europa. Nor are passcard sprites visible enough for that to be relevant, 99.9% of the time, passcards are attached to clothing and serve as just a piece of background information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, didn't know the details re: the lore team. Thanks for the heads up, approved!
Trialdev spriter here, I'd say they could use with being centered. They are also somewhat larger outright. In this comparison I overlayed the (I think) currently largest passcard, the Burzsian one, over it, and then a Dominian card, which is of more standard passcard size, over it again. Hopefully it is visible enough: The second one I will not put too much weight into, however. It'd make the flags less detailed if resized too drastically, I'll leave this one to realdev spriters if it is a big deal or not. Beside these two that'd be all from me. Cool stuff. |
This PR adds a variety of new passcards by The Ill-Fated, which are for a large variety of Solarian states.