Expands Notice Boards For Persistency #21211
Conversation
BotBOREALIS
added
Changelog Required
Sprites
Co-authored-by: FlamingLily <80451102+FlamingLily@users.noreply.github.com> Signed-off-by: KingOfThePing <43940569+KingOfThePing@users.noreply.github.com>
Co-authored-by: FlamingLily <80451102+FlamingLily@users.noreply.github.com> Signed-off-by: KingOfThePing <43940569+KingOfThePing@users.noreply.github.com>
|
After a discussion on Discord, going to add proper perspective directional sprites. Will need a few days. !wip |
BotBOREALIS
added
the
WIP
There was a problem hiding this comment.
I have some suggestions to reduce duplicate code in the comboard by refactoring some things in the regular notice board and using those refactorings in the comboard.
This makes the comboard not only cleaner, but easier to manage and perhaps easier to add more board types in the future.
Arrow768
added
the
Changes Required
This comment was marked as outdated.
This comment was marked as outdated.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
This comment was marked as outdated.
This comment was marked as outdated.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
|
!review |
About PR
This PR re-sprites and expands notice boards.
With the persistence update I expect an increase in utilizing notice boards. The current ones are quite old and severely limited by only allowing five pieces of paper tacked onto them.
So let us change that:
(updated final iteration)
Close up of the glass overlay:
Regular notice boards now support up to twenty (20) pieces of highly informative pieces of paper pinned up by the crew.
Command (lockable) notice boards support up to six (6) pieces of very important information by your beloved departmental heads.
FAQ
Q: Why is there a discrepancy between the command and regular notice boards?
A: Command is expected to pin up actually important information. The incentive is that command is a bit more conscious what they pin in these, now that they persist through rounds.
Q: Why twenty for the regular board?
A: Super full notice boards are funny. I may add even more, depending on how long I need to finish the code.
Q: Why is there stuff in the screenshots redacted?
A: It is for a feature for the command notice boards but I am not sure yet if it is desirable or practical to have.
Q: Why does your code look so bad?
A: Sorry :( I put up the PR so I get help or co-authored by people who actually know what they are doing.
Important
The new notice boards have not been mapped in yet! 😃