Skip to content

Conversation

FabianK3
Copy link
Contributor

@FabianK3 FabianK3 commented Aug 18, 2025

Summary

This PR adds trash to the persistence system.

  • Trash becomes persistent the moment it is dropped unless it is dropped in a maint or the disposal room.
  • It looses persistence when it lands in a maint/disposal room or gets picked up again.
  • Persistent trash can be found up to three days.

Those are the base rules, some trash types have additional rules.

List of trash to be implemented:

  • Basic trash (snacks and such)
    • Cigarette buts
    • spitwad
    • Burned matches
  • Broken bottles
  • Torn inflatable (-doors)

Littering is a i120 violation and can be punished with 3-7 minutes of prison time or with a 40-150 credit fine.
Stop littering and keep the ship clean.

Follow-up tasks

  • Update GitHub Wiki: Add section on how to add persistent trash types.
  • Update GitHub Wiki: Make persistence_get_content nullable/empty.

@FabianK3
Copy link
Contributor Author

!wip

@BotBOREALIS BotBOREALIS added the WIP The PR is a work in progress and should not be reviewed yet. label Aug 18, 2025
@FabianK3 FabianK3 requested a review from DreamySkrell as a code owner August 24, 2025 22:00
@github-actions github-actions bot added the 🗺️ Mapping - Horizon The PR touches the Horizon map files. label Aug 24, 2025
@FabianK3 FabianK3 requested a review from Arrow768 August 25, 2025 00:44
@FabianK3
Copy link
Contributor Author

FabianK3 commented Aug 25, 2025

Scope freeze. List of trash types is good for the start.

Testing and refactoring.

@FabianK3
Copy link
Contributor Author

FabianK3 commented Sep 3, 2025

Test cases

Subsystem specific:

  • Saving of empty track content list
  • Loading of empty track content list

Trash persistence specific:

  • Persistence in generic areas
  • Non-persistence in maints
  • Non-persistence in custodial areas
  • Revert of persistence on pickup

Trash type specific:

  • Cigarettes
  • Burned matches
  • Random type of snacks
  • Broken bottle
  • Inflatable-/door

Edit: Removed energy cans and autoinjectors due to out-of scope reagent changes required. At least for now.

@FabianK3
Copy link
Contributor Author

!review

@BotBOREALIS BotBOREALIS added Review Required and removed WIP The PR is a work in progress and should not be reviewed yet. labels Sep 14, 2025
@FabianK3
Copy link
Contributor Author

FabianK3 commented Sep 14, 2025

Please update the GitHub persistency wiki page with a new version on-merge:
persistency_wiki_update_version.md
This file contains the whole new page for replacement.

@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Sep 15, 2025
Merged via the queue into Aurorastation:master with commit 1ccfd0a Sep 15, 2025
25 checks passed
@FabianK3 FabianK3 deleted the persistent-trash branch September 15, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🗺️ Mapping - Horizon The PR touches the Horizon map files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants