Skip to content

Commit 26c2062

Browse files
committed
- Add tests for log.py
- Modify log levels to be lower case
1 parent effe388 commit 26c2062

File tree

2 files changed

+38
-6
lines changed

2 files changed

+38
-6
lines changed

src/log.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@ def __init__(self, log_level_str: str):
1111
self.logger = self.initialize_logging()
1212

1313
def get_log_level(self, log_level: str) -> int:
14-
log_level = log_level.upper()
15-
16-
if log_level == "DEBUG":
14+
if log_level == "debug":
1715
log_level = logging.DEBUG
18-
elif log_level == "INFO":
16+
elif log_level == "info":
1917
log_level = logging.INFO
20-
elif log_level == "WARNING":
18+
elif log_level == "warn":
2119
log_level = logging.WARNING
22-
else:
20+
elif log_level == 'error':
2321
log_level = logging.ERROR
22+
else:
23+
raise ValueError("Invalid logger level specified: {}".format(log_level))
2424

2525
return log_level
2626

src/tests/test_log.py

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
"""
2+
Tests for the Logging class.
3+
"""
4+
import pytest
5+
6+
# Astro modules
7+
from src.log import Logger
8+
9+
10+
class TestLogging:
11+
@pytest.mark.parametrize('level', ['debug', 'info', 'warn', 'error', 'asdf'])
12+
def test_get_log_level(self, level):
13+
valid_levels = ['debug', 'info', 'warn', 'error']
14+
15+
if level in valid_levels:
16+
logger = Logger(level)
17+
log_level = logger.get_log_level(level)
18+
19+
if level == 'debug':
20+
assert log_level == 10
21+
elif level == 'info':
22+
assert log_level == 20
23+
elif level == 'warn':
24+
assert log_level == 30
25+
elif level == 'error':
26+
assert log_level == 40
27+
28+
else: # should assert error if invalid log level specified
29+
with pytest.raises(ValueError) as exception:
30+
logger = Logger(level) # this will call get_log_level()
31+
32+
assert str(exception.value) == "Invalid logger level specified: {}".format(level)

0 commit comments

Comments
 (0)