Add loading bar #48
Merged
Add loading bar #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new field to the VideoData class to capture the video title for display purposes in a later change
- Added progress.py, which implements AstroProgress that acts as a wrapper for rich.Progress
- Added log method to allow objects to check log level
- might use this to conditionally enable certain features based on log level
Closed
Minimum allowed line rate is |
AustinCullar
commented
Oct 12, 2024
AustinCullar
commented
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A progress bar was added to track the downloading of comments. This is implemented with rich.Progress. I've written my own
AstroProgresswrapper class aroundrich.Progressto simplify the interface for my needs.Additional work:
VideoDataclass to track video title