Skip to content

Commit 963346a

Browse files
committed
updated references to tasks packages to include pydra-tasks-*
1 parent 1db9f86 commit 963346a

File tree

7 files changed

+40
-13
lines changed

7 files changed

+40
-13
lines changed

conftest.py

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,14 @@ class BidsAppTestBlueprint:
7474
/ "bidsapp"
7575
)
7676
test_bids_data_dir = (
77-
Path(__file__).parent / "tests" / "data" / "mri" / "human" / "neuro" / "bidsapp"
77+
Path(__file__).parent
78+
/ "tests"
79+
/ "data"
80+
/ "specs"
81+
/ "mri"
82+
/ "human"
83+
/ "neuro"
84+
/ "bidsapp"
7885
)
7986

8087
bids_specs = [str(p.stem) for p in bids_apps_dir.glob("*.yaml")]
@@ -162,19 +169,35 @@ def upload_test_dataset_to_xnat(
162169
continue
163170
mdata = DicomDir(test_scan_dir / "DICOM").metadata
164171
# Create scan
172+
series_number = int(mdata["SeriesNumber"])
173+
while True:
174+
try:
175+
xsession.scans[str(series_number)]
176+
except KeyError:
177+
break
178+
else:
179+
series_number += 1000
165180
xscan = xclasses.MrScanData(
166-
id=mdata["SeriesNumber"],
181+
id=series_number,
167182
type=varname2path(test_scan_dir.stem),
168183
series_description=mdata["SeriesDescription"],
169184
parent=xsession,
170185
)
171186

172187
for resource_path in test_scan_dir.iterdir():
173188

189+
if not resource_path.is_dir():
190+
continue
174191
# Create the resource
175192
xresource = xscan.create_resource(resource_path.stem)
176193
# Create the dummy files
177194
xresource.upload_dir(resource_path, method="tar_file")
178195

179196
# Populate metadata from DICOM headers
180-
login.put(f"/data/experiments/{xsession.id}?pullDataFromHeaders=true")
197+
try:
198+
login.put(f"/data/experiments/{xsession.id}?pullDataFromHeaders=true")
199+
except xnat.exceptions.XNATResponseError as e:
200+
logger.warning(
201+
f"Failed to pull metadata from DICOM headers for session {xsession.id} "
202+
f"with error: {e}"
203+
)

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ dependencies = [
1111
"fileformats",
1212
"fileformats-medimage",
1313
"pydra >=0.23a0",
14-
"pydra-mrtrix3",
15-
"pydra-fastsurfer",
14+
"pydra-tasks-mrtrix3",
15+
"pydra-tasks-fastsurfer",
1616
]
1717
license = "CC-BY-4.0"
1818
authors = [{ name = "Thomas G. Close", email = "tom.g.close@gmail.com" }]

specs/australian-imaging-service/mri/human/neuro/bidsapp/fmriprep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ base_image:
88
packages:
99
pip:
1010
- pydra-tasks-dcm2niix
11-
- pydra-mrtrix3
11+
- pydra-tasks-mrtrix3
1212
- pydra-compose-bidsapp
1313
neurodocker:
1414
dcm2niix: v1.0.20250506

specs/australian-imaging-service/mri/human/neuro/bidsapp/mriqc.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ docs:
1717
packages:
1818
pip:
1919
- pydra-tasks-dcm2niix
20-
- pydra-mrtrix3
20+
- pydra-tasks-mrtrix3
2121
- pydra-compose-bidsapp
2222
neurodocker:
2323
dcm2niix: v1.0.20250506

specs/australian-imaging-service/mri/human/neuro/bidsapp/smriprep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ base_image:
1313
packages:
1414
pip:
1515
- pydra-tasks-dcm2niix
16-
- pydra-mrtrix3
16+
- pydra-tasks-mrtrix3
1717
- pydra-compose-bidsapp
1818
neurodocker: # neurodocker templates freesurfer and fsl are already in smriprep image
1919
dcm2niix: v1.0.20250506

specs/australian-imaging-service/mri/human/neuro/t1w/preprocess.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ base_image:
99
packages:
1010
# Install dependencies for DICOM->NIfTI conversion
1111
pip:
12-
pydra-mrtrix3: 3.0.4a9
13-
pydra-fsl:
12+
pydra-tasks-mrtrix3: 3.0.4a9
13+
pydra-tasks-fsl:
1414
fileformats:
15-
pydra-fastsurfer:
15+
pydra-tasks-fastsurfer:
1616
fileformats-medimage-extras:
1717
fileformats-medimage-mrtrix3: 3.0.4a12
1818
fileformats-medimage-mrtrix3-extras: 3.0.4a12
@@ -110,7 +110,7 @@ commands:
110110
# mrtrix_lut_dir: /parcellations # /opt/mrtrix3-3.0.2/share/mrtrix3/labelconvert
111111
# freesurfer_home: &freesurfer_home !join ["/opt/freesurfer-", *freesurfer_version]
112112
# fs_license: *freesurfer_license
113-
# cache_dir: /work/pydra-cache
113+
# cache_dir: /work/pydra-tasks-cache
114114
# fastsurfer_executable:
115115
# - /fastsurfer/Docker/entrypoint.sh
116116
# - /fastsurfer/run_fastsurfer.sh
@@ -157,7 +157,7 @@ commands:
157157
mrtrix_lut_dir: /parcellations # /opt/mrtrix3-3.0.2/share/mrtrix3/labelconvert ## should this be
158158
freesurfer_home: &freesurfer_home !join ["/opt/freesurfer-", *freesurfer_version] ## freesurfer_home: *freesurfer_home
159159
fs_license: *freesurfer_license
160-
cache_dir: /work/pydra-cache
160+
cache_dir: /work/pydra-tasks-cache
161161
fastsurfer_executable:
162162
- /fastsurfer/Docker/entrypoint.sh
163163
- /fastsurfer/run_fastsurfer.sh

src/australianimagingservice/mri/human/neuro/t1w/tests/test_preprocess.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
Path(__file__).parent / ".." / ".." / ".." / ".." / ".." / ".." / ".."
77
).resolve()
88

9+
import pytest
910

11+
12+
@pytest.mark.skip
1013
def test_t1w_preprocess():
1114
wf = all_parcs(
1215
"/opt/FastSurfer",
@@ -16,6 +19,7 @@ def test_t1w_preprocess():
1619
)
1720

1821

22+
@pytest.mark.skip
1923
def test_t1w_preprocess_yaml(tmp_path: Path):
2024
app = App.load(
2125
PKG_DIR

0 commit comments

Comments
 (0)