Fix scene index cmake build#2631
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix CMake builds when scene_index is built as a shared plugin by ensuring ENABLE_SCENE_INDEX is defined for the relevant shared-library targets.
Changes:
- Add
ENABLE_SCENE_INDEX=1compile definition to thesceneIndexArnoldshared library target. - Add
ENABLE_SCENE_INDEX=1compile definition to theusdImagingArnoldshared library target whenBUILD_SCENE_INDEX_PLUGINis enabled (currently redundant with an existing definition in the same file).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/usd_imaging/CMakeLists.txt | Adds an ENABLE_SCENE_INDEX compile definition for the shared plugin (but duplicates an existing block). |
| plugins/scene_index/CMakeLists.txt | Adds missing ENABLE_SCENE_INDEX compile definition for the sceneIndexArnold shared plugin target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
+50
| if (BUILD_SCENE_INDEX_PLUGIN) | ||
| target_compile_definitions(usdImagingArnold PUBLIC ENABLE_SCENE_INDEX=1) | ||
| endif() |
| if (MTOA_BUILD) | ||
| target_compile_definitions(sceneIndexArnold PRIVATE MTOA_BUILD=1) | ||
| endif() | ||
| target_compile_definitions(sceneIndexArnold PUBLIC ENABLE_SCENE_INDEX=1) |
sebastienblor
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request