-
Notifications
You must be signed in to change notification settings - Fork 61
Game Piece Asset Support [AARD-1902]
#1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 33 commits
b4237fb
b7f00f4
96c74ac
b1731f4
cd697ae
0dfe38f
62ffc2c
5563f31
397e549
65e21e1
5fbdad8
6977e3d
b7f68cc
207b499
063c3c5
527c574
46506bc
c12a1da
16d6460
aa8c90c
ce59c85
0f374a5
68b0468
46921c7
8371f7f
a0cd719
012dd94
1d59de8
cf27e05
b81dcbe
9e94986
17d7c5c
bfafbd7
aff8e94
a2b0702
e788d25
ded6bca
154926e
f737962
d7f409b
23c4001
e1e6937
0ee5339
e126ab6
f963ab6
9d33a93
ae4efb5
10ab860
81a4651
761245f
d396a5b
4356435
b63cfc8
5b88b01
e0f53d4
3c8ebcc
ef91632
9b7d649
38dc6e7
88ac88c
a211bc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
"scripts": { | ||
"init": "(bun run assetpack && bun run playwright:install) || (npm run assetpack && npm run playwright:install)", | ||
"host": "vite --open --host", | ||
"dev": "vite --open", | ||
"dev": "vite", | ||
"build": "tsc && vite build", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might be worth reverting but it does not make a difference. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just personally find it really annoying when a new tab opens, since I usually already have one. I'm happy to revert this if it's something other people like though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can always just use |
||
"build:prod": "tsc && vite build --base=/fission/ --outDir dist/prod", | ||
"build:dev": "tsc && vite build --base=/fission-closed/ --outDir dist/dev", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we removing this
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we should not, it's a meaningful part of the exporter, we should just git ignore it (while keeping it on this upstream for people to download).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but fusion seems to just mess with this stuff itself, I don't think you should commit the changes though. You can't gitignore them though if they're already tracked