-
Notifications
You must be signed in to change notification settings - Fork 61
Exporter UI Refactor [AARD-1883]
#1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
553417a
to
cea6ff1
Compare
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and worked to export Dozer, I just have a couple nitpicks
exporter/SynthesisFusionAddin/web/src/ui/MaterialTaggingTab.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. For some reason when I add dozer's face to the material tagging table it disappears when I close and reopen the exporter, even though other components (e.g. wheels) stay there. I think it might have something to do with it being linked from another document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruv-0-Arora I had that a while ago in testing but thought I fixed it, do you have logs/a way to reproduce? |
I wasn't able to reproduce it again. It might have been some problem with the web build that I had done previously although unlikely since I do recall rebuilding the exporter UI (because I had deleted it prior to building it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click the "save" button, I get this error
This looks like a bug manifested from Fusion caching stuff. I don't have any evidence for that other than my intuition of working with Fusion's python api.
Like I said before I really should have done this last summer. Looks amazing, nice work.
* dev: (35 commits) Per Incident Penalty Format Unit Test Fix Format Unconditional Overwrite Fix Format Camera tries to find a focus if no focus exists Action Link Updated fix: remove analytics stuff (oopsie) fix: merge issue fix: remove eslint and prettier configs fix: make biome actually enforce eslint's rules, include react rules Clearer Config Format PR Feedback Format Scene Object Test Improvements Eslint Removed fix: update bun lockfile Update DefaultMatchModeConfigs.ts ...
Manually silencing chorus warning:
|
Task
AARD-1883
Uses Fusion's palette system to make the UI for the exporter a React webpage. Goal is to make the UI cleaner, easier to build on, and not such a pain to update.
Symptom
When you click the exporter button in fusion, you previously saw the old UI. The old UI was difficult to update and very inflexible in its layout.
Solution
ConfigureCommand
GUI replaced with a palette, which has all of the same inputs re-implemented using MUI and ReactPhotos
Limitations
Verification
ExporterOptions
objects were the same with both the old configuration UI and the new web UIBefore merging, ensure the following criteria are met: