Skip to content

UI Refactor #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: dev
Choose a base branch
from
Draft

UI Refactor #1223

wants to merge 18 commits into from

Conversation

PepperLola
Copy link
Member

@PepperLola PepperLola commented Jul 17, 2025

UI Refactor

AARD-1903

Refactored UI to improve the process of creating and using modals and panels. Rather than registering each possible UI element and then opening them with hardcoded IDs, the UI element itself is now passed into the relevant open* functions. In a tsx file, this looks something like openPanel(<ConfigurePanel />) but in regular .ts files it would look like openPanel(React.createElement(ConfigurePanel)).

TODO: write more

Creating UI Screens

A UI screen is what I decided to call the combination of panel/modal.
...

Opening UI Screens

...

Closing UI Screens

...

Rendering Toasts

...

Adding Callbacks

...


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@PepperLola PepperLola self-assigned this Jul 17, 2025
@PepperLola PepperLola added ui/ux Relating to user interface, or in general, user experience refactor The most important part of software development. javascript Pull requests that update javascript code labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update javascript code refactor The most important part of software development. ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant