-
Notifications
You must be signed in to change notification settings - Fork 62
UI Refactor #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PepperLola
wants to merge
18
commits into
dev
Choose a base branch
from
jwrigh/1903/ui-refactor
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
UI Refactor #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… buttons, made buttons contained by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update javascript code
refactor
The most important part of software development.
ui/ux
Relating to user interface, or in general, user experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Refactor
AARD-1903
Refactored UI to improve the process of creating and using modals and panels. Rather than registering each possible UI element and then opening them with hardcoded IDs, the UI element itself is now passed into the relevant
open*
functions. In atsx
file, this looks something likeopenPanel(<ConfigurePanel />)
but in regular.ts
files it would look likeopenPanel(React.createElement(ConfigurePanel))
.TODO: write more
Creating UI Screens
A UI screen is what I decided to call the combination of panel/modal.
...
Opening UI Screens
...
Closing UI Screens
...
Rendering Toasts
...
Adding Callbacks
...
Before merging, ensure the following criteria are met: